New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix and refactor test-fs-watch-non-recursive #25386

Closed

Trott wants to merge 2 commits into nodejs:master from Trott:test-fs-watch-non-recursive

Member

Trott commented Jan 8, 2019

test-fs-watch-non-recursive was loading the common/tmpdir module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

The test was duplicating some functionality in the tmpdir module. Use tmpdir module instead.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Trott added 2 commits

January 7, 2019 21:52


          test: fix test/pummel/test-fs-watch-non-recursive.js

2daeff0

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.


          test: refactor test-fs-watch-non-recursive

bcd34ac

The test was duplicating some functionality in the `tmpdir` module.

Collaborator

nodejs-github-bot commented Jan 8, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2173/pipeline

nodejs-github-bot added the test label

Member Author

Trott commented Jan 8, 2019

pummel tests are not run in CI, so lite CI should be sufficient

cjihrig approved these changes

View reviewed changes

richardlau approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

Trott added the author ready label

Member Author

Trott commented Jan 10, 2019

Landed in e18b461...fa5af0d

Trott closed this

Trott added a commit to Trott/io.js that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

82f03f8

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          test: refactor test-fs-watch-non-recursive

fa5af0d

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

65dfeeb

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit that referenced this pull request


          test: refactor test-fs-watch-non-recursive

837ca76

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR mentioned this pull request

v11.7.0 proposal #25537

Merged

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

6cc9885

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request


          test: refactor test-fs-watch-non-recursive

43616b2

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request

v11.8.0 proposal #25687

Merged

BethGriggs pushed a commit that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

4338f98

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: refactor test-fs-watch-non-recursive

62d93d6

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs mentioned this pull request

v10.16.0 proposal #27514

Merged

BethGriggs pushed a commit that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

a3e8b55

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: refactor test-fs-watch-non-recursive

5ab0410

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: fix test/pummel/test-fs-watch-non-recursive.js

82bc4ac

test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: refactor test-fs-watch-non-recursive

82dd321

The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced May 29, 2019

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315

Closed

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316

Closed

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317

Closed

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318

Closed

beevelop mentioned this pull request

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319

Closed

snyk-bot mentioned this pull request

[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark radiumrasheed/node#4

Open

Trott deleted the test-fs-watch-non-recursive branch

January 13, 2022 22:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready test