Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,worker: verify that .terminate() breaks microtask queue #25480

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jan 13, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2019
@addaleax
Copy link
Member Author

@addaleax
Copy link
Member Author

(I’m noticing that it probably hasn’t been resolved, because adding while(true); at the end of the loop() function still makes the test hang?)

@hashseed
Copy link
Member

I haven't had time to take a look there yet. I think it has already been fixed, but there may be some cases where things are still not working correctly.

@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2019
@addaleax
Copy link
Member Author

@addaleax
Copy link
Member Author

addaleax commented Jan 21, 2019

The Windows results look like infra failures, so I’m a bit confused…

Full New CI: https://ci.nodejs.org/job/node-test-pull-request/20245/ (✔️ )

@richardlau
Copy link
Member

richardlau commented Jan 22, 2019

The Windows results look like infra failures, so I’m a bit confused…

FYI, binaries are currently deleted after 7 days (nodejs/build#1515 (comment)) so you have that long to resume a build, after which you will need to kick off a brand new CI.

@danbev
Copy link
Contributor

danbev commented Jan 22, 2019

Landed in 2c9e12e.

@danbev danbev closed this Jan 22, 2019
danbev pushed a commit that referenced this pull request Jan 22, 2019
PR-URL: #25480
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 23, 2019
PR-URL: #25480
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
@addaleax addaleax deleted the worker-µtask-terminate branch February 8, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants