Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add metadata to report docs #25708

Closed
wants to merge 1 commit into from
Closed

doc: add metadata to report docs #25708

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Fixes: #25682

I based the metadata based on the other files in doc/ (we don't seem to have much (any?) documentation on what metadata should be included).

cc @nodejs/documentation

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2388/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. report Issues and PRs related to process.report. labels Jan 25, 2019
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@addaleax
Copy link
Member

Landed in f40778e

@addaleax addaleax closed this Jan 25, 2019
addaleax pushed a commit that referenced this pull request Jan 25, 2019
@richardlau @addaleax
doc: add metadata to report docs
f40778e 
Fixes: #25682

PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@richardlau @addaleax
doc: add metadata to report docs
e475119 
Fixes: #25682

PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-doc failed to add alternative version links
5 participants
@richardlau @nodejs-github-bot @vsemozhetbyt @addaleax @cjihrig