Refactor mac installer (Rebase of #776 against master)

[fhemberger]

Can you please check, if the Mac installer is built and working correctly?

[pmq20]

Given that tools/osx-pkg.pmdoc/index.xml.tmpl has been deleted, why Makefile still has a line [1] read cat tools/osx-pkg.pmdoc/index.xml.tmpl?

[1] https://github.com/fhemberger/node/blob/refactor-mac-installer-rebase/Makefile#L351

[fhemberger]

Because I forgot to remove it. ;) Good catch, thanks!

[remixz]

This needs to be changed to touch tools/osx-pkg/scripts/nodejs-run-uninstall

[remixz]

With the couple of changes I noted on the files, this builds! 🎉 This is great, cheers to you @fhemberger. I had tried to rebase it a little while ago, but I unfortunately didn't get far. I'm very glad you did. 😄

[fhemberger]

@remixz Phew, I'm glad it worked out. Thanks for your help!

[Fishrock123]

Linking: #776

[silverwind]

Very minor issue with the current installer: The logo is not scaled properly and is telling me 'No' :)

[fhemberger]

For the sidebar, I think we should go with a colored version oft the hexagon, instead of scaling the logo down. What do you think?

[silverwind]

👍 would make better use of the available space than the scaled logo.

[fhemberger]

Can someone please confirm that the rebased version is building correctly?
Also updated the installer logo:

[fhemberger]

@nodejs/build Can we please merge this? Various incarnations of this PR have been open for months now, and I'd like to get this done, so we can start with the actual translation work (same for the Windows installer).

[rvagg]

yes, but no, needs changes on the build machines so requires some additional work and testing, non-trivial merge, I'm sorry that I'm currently holding this one up, I'll (a) be trying to get to this as soon as I can and (b) removing myself as a bottleneck as we get more of the build team access to the osx machines

[fhemberger]

< insert (almost) monthly nag here > 😄

As v5 seems to be already waiting around the corner, it would be great if this could land as well.

[jasnell]

Does this supersede / replace #776?

[silverwind]

@fhemberger can you provide some build instructions for the installer, so I can test it?

[fhemberger]

@jasnell Yes, it's the changes of #776 rebased against the current master.

@silverwind Install Packages, then build for OS X:

./configure
make
make pre-pkg
make install DESTDIR=out/dist-osx
/usr/local/bin/packagesbuild tools/osx-pkg/osx-pkg-out.pkgproj

[silverwind]

Gave it a few installs/uninstalls and it looks to be working great. Only nag I have is that it says 'Node.js was installed' after uninstalling. Other than that, LGTM.

[evanlucas]

The current packages are named node-vx.x.x.pkg. This changes that to nodejs-vx.x.x.pkg. I would think that could break some external tools maybe?

[silverwind]

Should be the node scheme: https://nodejs.org/dist/v4.2.1/

[fhemberger]

@evanlucas Good catch, fixed.

[evanlucas]

what happens if it was installed to a custom location?

[fhemberger]

You can't choose a custom location in the installer.

Sorry, the screenshot is German but you get the idea.

[evanlucas]

ah good point

[evanlucas]

Do we have a retina image available for the sidebar? I wonder if packages even supports that. If so, we should probably add that.

This seems to work well. @rvagg if there is anything I can do to help on the build side of things to get this in for v5.0.0, feel free to let me know :] Overall, LGTM for whenever this can land.

[jbergstroem]

@evanlucas mac installers surely must be able to render a svg, no?