Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "lib,src: add unix socket getsockname/getpeername" #2584

Merged
merged 1 commit into from
Aug 27, 2015
Merged

Revert "lib,src: add unix socket getsockname/getpeername" #2584

merged 1 commit into from
Aug 27, 2015
+15 −65

Commits on Aug 27, 2015

  1. Revert "lib,src: add unix socket getsockname/getpeername" 

    This reverts commit 6cd0e26.
This reverts commit 7a999a1.
This reverts commit f337595.

It turns out that on Windows, uv_pipe_getsockname() is a no-op for
client sockets.  It slipped through testing because of a CI snafu.

PR-URL: nodejs#2584
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @bnoordhuis
    bnoordhuis committed Aug 27, 2015
    Configuration menu
    Copy the full SHA
    de88255 View commit details
    Browse the repository at this point in the history