Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-http-agent-timeout-option (again) #25886

Closed

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 2, 2019

There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the 'timeout' event from the
socket to the ClientRequest instance is added to the socket.

Refs: #25854 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the `'timeout'` event from the
socket to the `ClientRequest` instance is added to the socket.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2019
@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2019
@lpinca
Copy link
Member Author

lpinca commented Feb 7, 2019

Landed in b8d9d4a.

@lpinca lpinca closed this Feb 7, 2019
@lpinca lpinca deleted the refactor/test-http-agent-timeout-option branch February 7, 2019 06:39
lpinca added a commit that referenced this pull request Feb 7, 2019
There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the `'timeout'` event from the
socket to the `ClientRequest` instance is added to the socket.

PR-URL: #25886
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the `'timeout'` event from the
socket to the `ClientRequest` instance is added to the socket.

PR-URL: #25886
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants