tools: refactor for arrow callbacks and trailing commas #26394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* standardize on arrow functions for callbacks * standaradize on trailing commas for multiline arrays
Enable ESLint rules for trailing commas and arrow callbacks in tools directory. These rules are also in place in the benchmark directory.
nodejs-github-bot
added
doc
richardlau
approved these changes
Mar 2, 2019
antsmartian
approved these changes
Mar 2, 2019
shisama
approved these changes
Mar 2, 2019
Trott
added
the
author ready
jasnell
approved these changes
Mar 2, 2019
BridgeAR
approved these changes
Mar 3, 2019
| process.on('exit', function() { | ||
| fs.closeSync(fd); | ||
| }); | ||
| process.on('exit', () => { fs.closeSync(fd); }); |
There was a problem hiding this comment.
Suggested change
| process.on('exit', () => { fs.closeSync(fd); }); | |
| process.on('exit', () => fs.closeSync(fd)); |
There was a problem hiding this comment.
I prefer it with { and } because it makes it clear that the function is not returning a value.
|
Landed in c7e628f...20c2ca8 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 4, 2019
* standardize on arrow functions for callbacks * standaradize on trailing commas for multiline arrays PR-URL: nodejs#26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 4, 2019
Enable ESLint rules for trailing commas and arrow callbacks in tools directory. These rules are also in place in the benchmark directory. PR-URL: nodejs#26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
* standardize on arrow functions for callbacks * standaradize on trailing commas for multiline arrays PR-URL: nodejs#26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Enable ESLint rules for trailing commas and arrow callbacks in tools directory. These rules are also in place in the benchmark directory. PR-URL: nodejs#26394 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes