Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup env.h #26451

Closed
wants to merge 3 commits into from
Closed

cleanup env.h #26451

wants to merge 3 commits into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 5, 2019
@lpinca
Copy link
Member

lpinca commented Mar 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21226/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019 •
edited
Loading

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21238/ ✅ (besides arm)

@danbev
Copy link
Contributor

danbev commented Mar 8, 2019 •
edited by BridgeAR
Loading

Re-run of failing node-test-commit-arm-fanned ✔️

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 8, 2019
@gengjiawen @BridgeAR
src: delete unused variable in env.h
c4015eb 
PR-URL: nodejs#26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 8, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethodNoSideEffect
dd23fc1 
PR-URL: nodejs#26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 8, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethod
68d1871 
PR-URL: nodejs#26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

Landed in db2a5b0...68d1871 🎉

@BridgeAR BridgeAR closed this Mar 8, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
src: delete unused variable in env.h
6a4bb9e 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethodNoSideEffect
cdf0e09 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethod
926649e 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: delete unused variable in env.h
a11cf30 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethodNoSideEffect
efadb10 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: delete unused method SetTemplateMethod
989fcef 
PR-URL: #26451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @lpinca @BridgeAR @danbev @nodejs-github-bot