Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: add --pending-deprecation to process.binding() #26500

Closed
wants to merge 3 commits into from
Closed

process: add --pending-deprecation to process.binding() #26500

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2019

Print a deprecation warning for process.binding() when using
--pending-deprecation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
process: add --pending-deprecation to process.binding()
5be6de9 
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2804/pipeline

cjihrig
cjihrig approved these changes Mar 7, 2019
View reviewed changes
lib/internal/bootstrap/pre_execution.js Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21331/

@BridgeAR BridgeAR added process Issues and PRs related to the process subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 8, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

tniessen
tniessen approved these changes Mar 8, 2019
View reviewed changes
doc/api/deprecations.md Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Mar 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21336/

@richardlau
Copy link
Member

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

None of the files changed in this PR are exclusive to process though.

@tniessen tniessen added the deprecations Issues and PRs related to deprecations. label Mar 8, 2019
@joyeecheung
Copy link
Member

None of the files changed in this PR are exclusive to process though.

I guess it should be safe to map lib/internal/bootstrap/* changes to process

ChALkeR
ChALkeR approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@addaleax
Copy link
Member Author

Landed in 148254744134793cd6556c9749658f3872b03d002

@addaleax addaleax closed this Mar 11, 2019
@addaleax addaleax deleted the process-binding-pd branch March 11, 2019 10:18
addaleax added a commit that referenced this pull request Mar 11, 2019
@addaleax
process: add --pending-deprecation to process.binding()
1482547 
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@addaleax @BridgeAR
process: add --pending-deprecation to process.binding()
9af6631 
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
process: add --pending-deprecation to process.binding()
ceebbfb 
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.