Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use Array#includes instead of Array#indexOf #26732

Closed
wants to merge 1 commit into from
Closed

lib: use Array#includes instead of Array#indexOf #26732

wants to merge 1 commit into from

Conversation

starkwang
Copy link
Contributor

@starkwang starkwang commented Mar 18, 2019 •
edited
Loading

Refs: #26568

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@starkwang build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2959/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 18, 2019
@starkwang
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21620/

@vsemozhetbyt vsemozhetbyt added refactor to ES6+ author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 18, 2019
starkwang added a commit that referenced this pull request Mar 21, 2019
@starkwang
lib: use Array#includes instead of Array#indexOf
c8d3a73 
PR-URL: #26732
Refs: #26568
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@starkwang
Copy link
Contributor Author

Landed in c8d3a73

@starkwang starkwang closed this Mar 21, 2019
refack
refack reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated 👍

targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@starkwang @targos
lib: use Array#includes instead of Array#indexOf
d41254d 
PR-URL: nodejs#26732
Refs: nodejs#26568
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@starkwang @targos
lib: use Array#includes instead of Array#indexOf
cc76f3f 
PR-URL: #26732
Refs: #26568
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@starkwang @nodejs-github-bot @refack @lpinca @targos @richardlau @vsemozhetbyt