Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: move big impl comment to /internal/ #26761

Closed
wants to merge 1 commit into from
Closed

timers: move big impl comment to /internal/ #26761

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

To be paired with the commits from
#26583

Specifically:
1a6fb71

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Fishrock123
timers: move big impl comment to /internal/
749d87b 
To be paired with the commits from
nodejs#26583

Specifically:
1a6fb71
@nodejs-github-bot
Copy link
Collaborator

@Fishrock123 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2977/pipeline

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 18, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2019
@Fishrock123 Fishrock123 self-assigned this Mar 20, 2019
@Fishrock123
Copy link
Contributor Author

Landed in 56199ec

@Fishrock123 Fishrock123 deleted the timers-move-big-comment branch March 21, 2019 00:12
Fishrock123 added a commit that referenced this pull request Mar 21, 2019
@Fishrock123
timers: move big impl comment to /internal/
56199ec 
To be paired with the commits from
#26583

Specifically:
1a6fb71

PR-URL: #26761
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Fishrock123 @targos
timers: move big impl comment to /internal/
a640834 
To be paired with the commits from
#26583

Specifically:
1a6fb71

PR-URL: #26761
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@Fishrock123 Fishrock123

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fishrock123 @nodejs-github-bot @apapirovski @joyeecheung @BridgeAR