Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: marking recent test failures as flaky #2679

Closed

Commits on Sep 2, 2015

  1. src: fix memory leak in ExternString

    v8 will silently return an empty handle
    which doesn't delete our data if string length is
    above String::kMaxLength
    
    Fixes: nodejs#1374
    PR-URL: nodejs#2402
    Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    skomski authored and trevnorris committed Sep 2, 2015
    6 Configuration menu
    Copy the full SHA
    617ee32 View commit details
    Browse the repository at this point in the history
  2. child_process: add callback parameter to .send()

    Add an optional callback parameter to `ChildProcess.prototype.send()`
    that is invoked when the message has been sent.
    
    Juggle the control channel's reference count so that in-flight messages
    keep the event loop (and therefore the process) alive until they have
    been sent.
    
    `ChildProcess.prototype.send()` and `process.send()` used to operate
    synchronously but became asynchronous in commit libuv/libuv@393c1c5
    ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed
    in io.js in commit 07bd05b ("deps: update libuv to 1.2.1").
    
    Fixes: nodejs#760
    PR-URL: nodejs#2620
    Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    bnoordhuis authored and trevnorris committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    56d9584 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2015

  1. test: mark eval_messages as flaky

    This test has failed recently during a PR test in Jenkins, for
    reasons seemingly not related to the change in the PR.
    
    PR-URL: nodejs#2648
    Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
    orangemocha committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    abbc8db View commit details
    Browse the repository at this point in the history
  2. doc: reorder collaborators by their usernames

    Fixes: nodejs#1972
    PR-URL: nodejs#2322
    Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
    Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    jbergstroem committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    6ce8f5f View commit details
    Browse the repository at this point in the history
  3. test: marking recent test failures as flaky

    These tests failed in either master builds, unrelated changes (like
    marking tests as flaky) or are properly discussed in the respective
    pull requests.
    joaocgreis committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    deea530 View commit details
    Browse the repository at this point in the history