Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small misc change in src folder 19-03-20 #26815

Closed
wants to merge 6 commits into from
Closed

small misc change in src folder 19-03-20 #26815

wants to merge 6 commits into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 20, 2019
@gengjiawen gengjiawen mentioned this pull request Mar 21, 2019
Merged
2 tasks
refack
refack approved these changes Mar 21, 2019
View reviewed changes
src/cares_wrap.cc Show resolved Hide resolved
@refack
Copy link
Contributor

refack commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21728/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@gengjiawen
Copy link
Member Author

@danbev can you import this, thanks.

@danbev
Copy link
Contributor

danbev commented Mar 28, 2019

Landed in 1b10f0d, 9addfef, 0601f16, 3440cf6, 78ae094, and 230f1f2.

@danbev danbev closed this Mar 28, 2019
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: delete unreachable code in heap_utils.cc
1b10f0d 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: tidy up include headers in env.cc
9addfef 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: delete unused field in class ModuleWrap
0601f16 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: use deleted function for class BaseObject
3440cf6 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: fix task release in cares_wrap.cc
78ae094 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to zys-contrib/node that referenced this pull request Mar 28, 2019
@gengjiawen @danbev
src: delete useless code in cares_wrap.cc
230f1f2 
PR-URL: nodejs#26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gengjiawen
Copy link
Member Author

Thanks :)

@gengjiawen gengjiawen deleted the small-misc-19-03-20 branch March 28, 2019 06:58
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: delete unreachable code in heap_utils.cc
65a1954 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: tidy up include headers in env.cc
6ee4b76 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: delete unused field in class ModuleWrap
c282388 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: use deleted function for class BaseObject
53e46f9 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: fix task release in cares_wrap.cc
3b2c775 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 28, 2019
@gengjiawen @targos
src: delete useless code in cares_wrap.cc
385c0b0 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: delete unreachable code in heap_utils.cc
ceb0d32 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: tidy up include headers in env.cc
a016650 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: delete unused field in class ModuleWrap
b883df0 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: use deleted function for class BaseObject
32cc3af 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: fix task release in cares_wrap.cc
6bf92f1 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 29, 2019
@gengjiawen @targos
src: delete useless code in cares_wrap.cc
a271968 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: delete unreachable code in heap_utils.cc
c1def07 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: tidy up include headers in env.cc
ea7e2c0 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: delete unused field in class ModuleWrap
c824127 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: use deleted function for class BaseObject
c969731 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: fix task release in cares_wrap.cc
6bfb17f 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@gengjiawen @targos
src: delete useless code in cares_wrap.cc
0427354 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: delete unreachable code in heap_utils.cc
e3d3852 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: tidy up include headers in env.cc
2c3bca4 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: delete unused field in class ModuleWrap
9a0aadc 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: use deleted function for class BaseObject
8d16edc 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: fix task release in cares_wrap.cc
ff8109f 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@gengjiawen @BethGriggs
src: delete useless code in cares_wrap.cc
fb37d13 
PR-URL: #26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @refack @danbev @BridgeAR @nodejs-github-bot