Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: expect error for test_lookup_ipv6_hint on FreeBSD #2724

Closed
wants to merge 1 commit into from
Closed

test: expect error for test_lookup_ipv6_hint on FreeBSD #2724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/internet/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,19 @@ TEST(function test_lookup_ipv6_hint(done) {
family: 6,
hints: dns.V4MAPPED
}, function(err, ip, family) {
if (err) throw err;
if (err) {
// FreeBSD does not support V4MAPPED
if (process.platform === 'freebsd') {
assert(err instanceof Error);
assert.strictEqual(err.code, 'EAI_BADFLAGS');
assert.strictEqual(err.hostname, 'www.google.com');
assert.ok(/getaddrinfo EAI_BADFLAGS/.test(err.message));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply assert

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used assert.ok() to match the style of the other regular expression-based assertions in the file. (There are five other instances.)

done();
return;
} else {
throw err;
}
}
assert.ok(net.isIPv6(ip));
assert.strictEqual(family, 6);

Expand Down