add node 12 to the first list of versions #27414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
targos
approved these changes
Apr 25, 2019
silverwind
reviewed
Apr 25, 2019
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| Select a Node.js version below to view the changelog history: | |||
|
|
|||
| * [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - **Current** | |||
| * [Node.js 12](doc/changelogs/CHANGELOG_V12.md) - **Current** | |||
| * [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - Current | |||
There was a problem hiding this comment.
11 should be End-of-Life I think.
There was a problem hiding this comment.
… but I think Maintenance would be accurate?
There was a problem hiding this comment.
Yes, I think it should. See the graphic on https://nodejs.org/en/about/releases/ but in the table, version 11 is with "current" label.
There was a problem hiding this comment.
Ok, then keep it. It's a bit weird we have two "Current" versions, but I guess that's intended.
addaleax
approved these changes
Apr 25, 2019
jasnell
approved these changes
Apr 26, 2019
silverwind
approved these changes
Apr 26, 2019
ZYSzys
approved these changes
Apr 26, 2019
silverwind
pushed a commit
that referenced
this pull request
Apr 26, 2019
PR-URL: #27414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
|
@silverwind the commit landed without a proper subsystem in title. |
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
PR-URL: #27414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
|
@lpinca yes that occured to me shortly after merging as well. Been a while since I did merges here, will be more careful next time :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist