Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: document NODE_COMMON_PORT env var #27507

Merged
merged 1 commit into from
May 3, 2019
Merged

test: document NODE_COMMON_PORT env var #27507

merged 1 commit into from
May 3, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 30, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3410

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 1, 2019
@cjihrig
test: document NODE_COMMON_PORT env var
9d4cbdd 
PR-URL: nodejs#27507
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@cjihrig cjihrig merged commit 9d4cbdd into nodejs:master May 3, 2019
@cjihrig cjihrig deleted the common-port branch May 3, 2019 01:18
targos pushed a commit that referenced this pull request May 4, 2019
@cjihrig @targos
test: document NODE_COMMON_PORT env var
e1d88aa 
PR-URL: #27507
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@richardlau richardlau richardlau approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @Trott @antsmartian @richardlau @ZYSzys