Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: honor --abort_on_uncaught_exception flag #2776

Merged
merged 2 commits into from
Sep 17, 2015
Merged

src: honor --abort_on_uncaught_exception flag #2776

merged 2 commits into from
Sep 17, 2015

Commits on Sep 17, 2015

  1. src: Add ABORT macro 

    Windows 8+ compiled in Release mode exits with code 0xC0000409 when
abort() is called. This prevents us from being able to reliably verify
an abort exit code (3) on windows.

PR-URL: nodejs#2776
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @evanlucas
    evanlucas committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    870229e View commit details
    Browse the repository at this point in the history

  2. src: honor --abort_on_uncaught_exception flag 

    Fix regression introduced in 0af4c9e
that ignores the --abort-on-uncaught-exception flag. Prior to that
commit, the flag was passed through to v8. After that commit, the
process just calls exit(1).

PR-URL: nodejs#2776
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @evanlucas
    evanlucas committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    921f2de View commit details
    Browse the repository at this point in the history