Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fall back to env->exec_path() for default profile directory #28252

Closed
wants to merge 2 commits into from
Closed

src: fall back to env->exec_path() for default profile directory #28252

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

src: save exec path when initializing Environment

src: fall back to env->exec_path() for default profile directory

When the current working directory is deleted, fall back to
exec_path as the default profile directory.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joyeecheung
src: save exec path when initializing Environment
51d3366
@joyeecheung
src: fall back to env->exec_path() for default profile directory
dfb69b9 
When the current working directory is deleted, fall back to
exec_path as the default profile directory.
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23922/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23923/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23949/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 18, 2019
@danbev
Copy link
Contributor

danbev commented Jun 19, 2019

Landed in 26bd0df, and ac1239e.

@danbev danbev closed this Jun 19, 2019
danbev pushed a commit that referenced this pull request Jun 19, 2019
@joyeecheung @danbev
src: save exec path when initializing Environment
26bd0df 
PR-URL: #28252
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit that referenced this pull request Jun 19, 2019
@joyeecheung @danbev
src: fall back to env->exec_path() for default profile directory
ac1239e 
When the current working directory is deleted, fall back to
exec_path as the default profile directory.

PR-URL: #28252
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@joyeecheung @targos
src: save exec path when initializing Environment
040b9db 
PR-URL: #28252
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@joyeecheung @targos
src: fall back to env->exec_path() for default profile directory
c491e4d 
When the current working directory is deleted, fall back to
exec_path as the default profile directory.

PR-URL: #28252
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @danbev @jasnell @addaleax