Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Worker + uncaughtException + process.exit() test #28259

Closed
wants to merge 2 commits into from
Closed

test: add Worker + uncaughtException + process.exit() test #28259

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added test Issues and PRs related to the tests. worker Issues and PRs related to Worker support. labels Jun 17, 2019
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@addaleax addaleax mentioned this pull request Jun 17, 2019
Closed
2 tasks
Trott
Trott requested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail if run with the tools/test.py --worker.

@joyeecheung
Copy link
Member

joyeecheung commented Jun 17, 2019 •
edited
Loading

Maybe put the worker code in a fixture instead? So it won't get run by --worker. Or just eval the code.

@addaleax
Copy link
Member Author

@joyeecheung @Trott I’ve updated this with the standard approach we use in our tests (using an env var instead of isMainThread)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23937/

@addaleax
Copy link
Member Author

Landed in 7146ddd

@addaleax addaleax closed this Jun 19, 2019
@addaleax addaleax deleted the worker-uncaught-exception branch June 19, 2019 17:07
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jun 19, 2019
@addaleax
test: add Worker + uncaughtException + process.exit() test
7146ddd 
PR-URL: nodejs#28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@addaleax @targos
test: add Worker + uncaughtException + process.exit() test
72f52a3 
PR-URL: #28259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@Trott Trott Trott approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @joyeecheung @fhinkel @Trott @gireeshpunathil