Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise strict mode text in assert #28285

Merged
merged 1 commit into from
Jun 21, 2019
Merged

doc: revise strict mode text in assert #28285

merged 1 commit into from
Jun 21, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 19, 2019

Revise the text describing strict mode.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jun 19, 2019
@Trott
Copy link
Member Author

Trott commented Jun 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3690/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2019
@Trott
doc: revise strict mode text in assert
3af27f8 
Revise the text describing `strict` mode.

PR-URL: nodejs#28285
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 21, 2019

Landed in 3af27f8

@Trott Trott merged commit 3af27f8 into nodejs:master Jun 21, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
doc: revise strict mode text in assert
1f2b8c8 
Revise the text describing `strict` mode.

PR-URL: #28285
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott Trott deleted the revise-strict-mode-yo branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @BridgeAR @trivikr @nodejs-github-bot