doc: cleanup pendingSettingsAck docs #28388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
Trott
reviewed
Jun 24, 2019
doc/api/http2.md
Outdated
| Indicates whether or not the `Http2Session` is currently waiting for an | ||
| acknowledgment for a sent `SETTINGS` frame. Will be `true` after calling the | ||
| `http2session.settings()` method. Will be `false` once all sent SETTINGS | ||
| Indicates whether or not the `Http2Session` is currently waiting for |
There was a problem hiding this comment.
Totally optional micro-suggestion:
Suggested change
| Indicates whether or not the `Http2Session` is currently waiting for | |
| Indicates whether the `Http2Session` is currently waiting for |
Trott
approved these changes
Jun 24, 2019
This commit rephrases the first sentence of the http2 session pendingSettingsAck property docs. It also formats SETTINGS consistently. PR-URL: nodejs#28388 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This commit rephrases the first sentence of the http2 session pendingSettingsAck property docs. It also formats SETTINGS consistently. PR-URL: #28388 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rephrases the first sentence of the http2 session
pendingSettingsAckproperty docs. It also formatsSETTINGSconsistently.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes