Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: assign missing deprecation code #28395

Closed
wants to merge 1 commit into from
Closed

worker: assign missing deprecation code #28395

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 23, 2019

Deprecation code was not assigned.

@nodejs/tooling ... might be worthwhile adding a check for DEP00XX and DEP0XXX in the change using git-node-land

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Jun 23, 2019
@jasnell jasnell added deprecations Issues and PRs related to deprecations. and removed worker Issues and PRs related to Worker support. labels Jun 23, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24072/

@addaleax
Copy link
Member

addaleax commented Jul 3, 2019

Landed in f5f8a18

@addaleax addaleax closed this Jul 3, 2019
@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jul 3, 2019
addaleax pushed a commit that referenced this pull request Jul 3, 2019
@jasnell @addaleax
worker: assign missing deprecation code
f5f8a18 
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@jasnell @targos
worker: assign missing deprecation code
cbf5401 
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
@richardlau richardlau mentioned this pull request Jul 14, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasnell @nodejs-github-bot @addaleax @Trott @lpinca @TimothyGu @cjihrig @richardlau @ZYSzys