Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: override authority with options #28584

Closed
wants to merge 1 commit into from
Closed

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 7, 2019

Make options.host and options.port take precedence over
authority.host and authority.port respectively.

Fixes: #28182

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Make `options.host` and `options.port` take precedence over
`authority.host` and `authority.port` respectively.

Fixes: nodejs#28182
@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jul 7, 2019
@Trott
Copy link
Member

Trott commented Jul 8, 2019

I imagine this doesn't require any documentation adjustments/improvements, but just in case, mentioning it here anyway.

@nodejs-github-bot
Copy link
Collaborator

@lpinca
Copy link
Member Author

lpinca commented Jul 10, 2019

Landed in e800f9d.

@lpinca lpinca closed this Jul 10, 2019
@lpinca lpinca deleted the gh-28182 branch July 10, 2019 14:24
lpinca added a commit that referenced this pull request Jul 10, 2019
Make `options.host` and `options.port` take precedence over
`authority.host` and `authority.port` respectively.

PR-URL: #28584
Fixes: #28182
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
Make `options.host` and `options.port` take precedence over
`authority.host` and `authority.port` respectively.

PR-URL: #28584
Fixes: #28182
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http2.connect(...) - overriding authority with options
6 participants