V12.x staging

.editorconfig

@@ -16,11 +16,11 @@ indent_size = 8
 indent_style = tab
 
 [{deps}/**]
-charset = ignore
-end_of_line = ignore
-indent_size = ignore
-indent_style = ignore
-trim_trailing_whitespace = ignore
+charset = unset
+end_of_line = unset
+indent_size = unset
+indent_style = unset
+trim_trailing_whitespace = unset
 
 [{test/fixtures,deps,tools/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
 insert_final_newline = false

.eslintrc.js

@@ -8,6 +8,10 @@ const path = require('path');
 const NodePlugin = require('./tools/node_modules/eslint-plugin-node-core');
 NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');
 
+// The Module._findPath() monkeypatching is to make it so that ESLint will work
+// if invoked by a globally-installed ESLint or ESLint installed elsewhere
+// rather than the one we ship. This makes it possible for IDEs to lint files
+// with our rules while people edit them.
 const ModuleFindPath = Module._findPath;
 const hacks = [
   'eslint-plugin-node-core',
@@ -39,6 +43,7 @@ module.exports = {
     {
       files: [
         'doc/api/esm.md',
+        'doc/api/modules.md',
         'test/es-module/test-esm-type-flag.js',
         'test/es-module/test-esm-type-flag-alias.js',
         '*.mjs',
@@ -59,13 +64,15 @@ module.exports = {
     'array-callback-return': 'error',
     'arrow-parens': ['error', 'always'],
     'arrow-spacing': ['error', { before: true, after: true }],
+    'block-scoped-var': 'error',
     'block-spacing': 'error',
     'brace-style': ['error', '1tbs', { allowSingleLine: true }],
     'capitalized-comments': ['error', 'always', {
       line: {
         // Ignore all lines that have less characters than 20 and all lines that
         // start with something that looks like a variable name or code.
-        ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std',
+        // eslint-disable-next-line max-len
+        ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp|(let|var|const) [a-z_A-Z0-9]+ =|[b-z] |[a-z]*[0-9].* ',
         ignoreInlineComments: true,
         ignoreConsecutiveComments: true,
       },
@@ -107,6 +114,7 @@ module.exports = {
       tabWidth: 2,
     }],
     'new-parens': 'error',
+    'no-async-promise-executor': 'error',
     'no-class-assign': 'error',
     'no-confusing-arrow': 'error',
     'no-const-assign': 'error',
@@ -140,7 +148,7 @@ module.exports = {
     'no-octal': 'error',
     'no-path-concat': 'error',
     'no-proto': 'error',
-    'no-redeclare': 'error',
+    'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
     /* eslint-disable max-len */
     'no-restricted-properties': [
@@ -184,7 +192,11 @@ module.exports = {
       },
       {
         selector: "CallExpression[callee.property.name='doesNotThrow']",
-        message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.',
+        message: 'Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead.',
+      },
+      {
+        selector: "CallExpression[callee.property.name='doesNotReject']",
+        message: 'Do not use `assert.doesNotReject()`. Write the code without the wrapper and add a comment instead.',
       },
       {
         selector: "CallExpression[callee.property.name='rejects'][arguments.length<2]",
@@ -229,12 +241,13 @@ module.exports = {
       {
         selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
         message: 'The first argument should be the `actual`, not the `expected` value.',
-      }
+      },
     ],
     /* eslint-enable max-len */
     'no-return-await': 'error',
     'no-self-assign': 'error',
     'no-self-compare': 'error',
+    'no-shadow-restricted-names': 'error',
     'no-tabs': 'error',
     'no-template-curly-in-string': 'error',
     'no-this-before-super': 'error',

.github/SUPPORT.md

@@ -0,0 +1,26 @@
+# Support
+
+Node.js contributors have limited availability to address general support
+questions. Please make sure you are using a [currently-supported version of
+Node.js](https://github.com/nodejs/Release#release-schedule).
+
+When looking for support, please first search for your question in these venues:
+
+* [Node.js Website](https://nodejs.org/en/), especially the
+  [API docs](https://nodejs.org/api/)
+* [Node.js Help](https://github.com/nodejs/help)
+* [Open or closed issues in the Node.js GitHub organization](https://github.com/issues?utf8=%E2%9C%93&q=sort%3Aupdated-desc+org%3Anodejs+is%3Aissue)
+
+If you didn't find an answer in the resources above, try these unofficial
+resources:
+
+* [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
+* [#node.js channel on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
+* [Node.js Slack Community](https://node-js.slack.com/)
+  * To register: [nodeslackers.com](http://www.nodeslackers.com/)
+
+GitHub issues are for tracking enhancements and bugs, not general support.
+
+The open source license grants you the freedom to use Node.js. It does not
+guarantee commitments of other people's time. Please be respectful and manage
+your expectations.

.gitignore

@@ -1,9 +1,13 @@
-# Whitelist dotfiles
+# Please take extra care not to add rules that will make tracked files ignored.
+# To test that, run `git ls-files -i --exclude-standard`.
+# To check why a specific file is ignored, run `git check-ignore -v <filepath>`.
+
+# === Rule for dotfiles ===
+# Ignore all dotfiles.
 .*
+# Exclude specific dotfiles that we want to track.
 !deps/**/.*
 !test/fixtures/**/.*
-!tools/node_modules/**/.*
-!tools/doc/node_modules/**/.*
 !.clang-format
 !.editorconfig
 !.eslintignore
@@ -19,109 +23,112 @@
 !.eslintrc.yaml
 !.cpplint
 
-core
-vgcore.*
-v8*.log
-perf.data
-perf.data.old
-tags
-*.pyc
-doc/api.xml
-tmp/
-test/tmp*/
-iojs
-iojs_g
-node
-node_g
-*.swp
-icu_config.gypi
-node_trace.*.log
-coverage/
-!**/node_modules/**/coverage
-
+# === Rules for root dir ===
+/core
+/vgcore.*
+/v8*.log
+/perf.data
+/perf.data.old
+/tags
+/doc/api.xml
+/node
+/node_g
+/*.exe
+/*.swp
 /out
+/*.txt
+
+# === Rules for artifacts of `./configure` ===
+/icu_config.gypi
+/config.gypi
+/config.status
+/config_fips.gypi
 
-# various stuff that VC++ produces/uses and is not in /out
-/Debug/
-/Release/
-!doc/blog/**
+# === Rules for MSVS artifacts ===
+/Debug
+/Release
 *.sln
-!nodemsi.sln
 *.suo
-*.vcxproj
-!custom_actions.vcxproj
-*.vcxproj.user
-*.vcxproj.filters
+*.vcxproj*
 UpgradeLog*.XML
 _UpgradeReport_Files/
 *.sdf
 *.opensdf
-*.VC.db
-*.VC.opendb
-/*.exe
+*.VC.*
+*.wixobj
+/tools/msvs/genfiles/
+/npm.wxs
+# Exclude MSVS files used for .msi file generation
+!tools/msvs/msi/custom_actions.vcxproj
+!tools/msvs/msi/nodemsi.sln
 
-/config.mk
-/config.gypi
-/config.status
-/config_fips.gypi
+# === Rules for GYP artifacts ===
 *-nodegyp*
-/gyp-mac-tool
-/npm.wxs
-/tools/msvs/npm.wixobj
-/tools/msvs/genfiles/
+/gyp-*-tool
 /test/addons/??_*/
-email.md
-deps/v8-*
-deps/icu
-deps/icu*.zip
-deps/icu*.tgz
-deps/icu-tmp
-./node_modules
-android-toolchain/
+/*.mk
 
+# === Rules for other build artifacts ===
+/email.md
+/deps/v8-*
+/deps/icu
+/deps/icu*.zip
+/deps/icu*.tgz
+/deps/icu-tmp
+./node_modules
+/android-toolchain/
 # generated by gyp on Windows
-deps/openssl/openssl.props
-deps/openssl/openssl.targets
-deps/openssl/openssl.xml
-
+/deps/openssl/openssl.props
+/deps/openssl/openssl.targets
+/deps/openssl/openssl.xml
 # generated by gyp on android
 /*.target.mk
 /*.host.mk
-deps/openssl/openssl.target.mk
-deps/zlib/zlib.target.mk
-
-!deps/npm/node_modules
-# not needed and causes issues for distro packagers
-deps/npm/node_modules/.bin/
+/deps/openssl/openssl.target.mk
+/deps/zlib/zlib.target.mk
 
-# build/release artifacts
+# === Rules for release artifacts ===
 /*.tar.*
 /*.pkg
 /SHASUMS*.txt*
 
-# api docs artifacts
-tools/doc/node_modules
-
-# clang-format artifacts
-tools/clang-format/node_modules
+# === Rules for `node_modules` ===
+!**/node_modules/**
+/node_modules
+/tools/doc/node_modules
+/tools/clang-format/node_modules
 
-# test artifacts
-icu_config.gypi
-*.tap
+# === Rules for test artifacts ===
+/*.tap
 /*.xml
+/node_trace.*.log
+# coverage related
+/gcovr
+/build
+/coverage
 
-# Xcode workspaces and project folders
+# === Rules for XCode artifacts ===
 *.xcodeproj
 *.xcworkspace
+*.pbxproj
 
-# libuv book and GitHub template
-deps/uv/.github/
-deps/uv/docs/code/
-deps/uv/docs/src/guide/
-
-# do not override V8's .gitignore
+# === Rules for files in `/deps` ===
+# Exclude all files in the vendored `npm`.
+!/deps/npm/node_modules
+# These are not needed and causes issues for distro packagers.
+/deps/npm/node_modules/.bin/
+# Respect V8's .gitignore
 !deps/v8/**
-# ignore VS compiler output unhandled by V8's .gitignore
-deps/v8/third_party/eu-strip/
+# Ignore the libuv book and GitHub templates
+/deps/uv/.github/
+/deps/uv/docs/code/
+/deps/uv/docs/src/guide/
+# Ignore dependencies fetched by deps/v8/tools/node/fetch_deps.py
+/deps/.cipd
 
+# === Global Rules ===
+# Keep last to avoid being excluded
+*.pyc
+__pycache__
 .DS_Store
+*~

.travis.yml

@@ -5,8 +5,10 @@ x-ccache-setup-steps: &ccache-setup-steps
   - export CXX='ccache g++-6'
 
 os: linux
-dist: xenial
 language: cpp
+env:
+  global:
+    - PYTHON_VERSION="2.7.15"
 jobs:
   include:
     - stage: "Compile"
@@ -20,7 +22,7 @@ jobs:
             - g++-6
       install: *ccache-setup-steps
       script:
-        - pyenv global 2.7.15
+        - pyenv global ${PYTHON_VERSION}
         - ./configure
         - make -j2 -C out V=1 v8
 
@@ -34,7 +36,7 @@ jobs:
             - g++-6
       install: *ccache-setup-steps
       script:
-        - pyenv global 2.7.15
+        - pyenv global ${PYTHON_VERSION}
         - ./configure
         - make -j2 V=1
         - cp out/Release/node /home/travis/.ccache
@@ -47,7 +49,7 @@ jobs:
         - mkdir -p out/Release
         - cp /home/travis/.ccache/node out/Release/node
       script:
-        - pyenv global 2.7.15
+        - pyenv global ${PYTHON_VERSION}
         - python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare default
 
     - name: "Test C++ Suites"
@@ -63,7 +65,7 @@ jobs:
         - cp /home/travis/.ccache/cctest out/Release/cctest
         - touch config.gypi
       script:
-        - pyenv global 2.7.15
+        - pyenv global ${PYTHON_VERSION}
         - out/Release/cctest
         - make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
         - python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api
@@ -72,7 +74,7 @@ jobs:
       language: node_js
       node_js: "node"
       install:
-        - pyenv global 2.7.15
+        - pyenv global ${PYTHON_VERSION}
         - make lint-py-build || true
       script:
         - NODE=$(which node) make lint lint-py