Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix 404 links #29661

Closed
wants to merge 1 commit into from
Closed

doc: fix 404 links #29661

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 23, 2019
@XhmikosR XhmikosR changed the title doc: fix 404 link in changelogs/CHANGELOG_V12.md doc: fix 404 links Sep 23, 2019
@XhmikosR
Copy link
Contributor Author

If anyone's in touch with mitre.org they should ask them to fix the www to naked redirection on their side. Weird that no one noticed this before.

@XhmikosR
Copy link
Contributor Author

BTW this is ongoing. I'm doing a first pass without scanning some links like github.com. I'm gonna update nodejs/nodejs.org#2424 when the scan is done requesting feedback for each link, but I'll push here any fixes in core docs in separate PRs. I'll keep this PR only for changelogs.

@XhmikosR
doc: fix 404 links
c7644b0 
For `www.cve.mitre.org` they don't seem to redirect www to naked.
@XhmikosR
Copy link
Contributor Author

I only found one more real broken link https://v8docs.nodesource.com/node-10.6/d5/dda/classv8_1_1_isolate.html#ac673576f24fdc7a33378f8f57e1d13a4. I'd expect the v8docs site to handle this redirect but apparently it doesn't.

Should I change this in this PR too? This could probably be backported, though.

@XhmikosR
Copy link
Contributor Author

What should I do about the broken v8docs link? Should I push it in this branch?

@Trott
Copy link
Member

Trott commented Sep 26, 2019 •
edited
Loading

What should I do about the broken v8docs link? Should I push it in this branch?

Let's do that in a separate PR. This way any discussion there won't delay these other fixes. For example, there might be discussion about using the official V8 docs somehow rather than NodeSource (although I seem to recall there was a good reason to use NodeSource, but I don't recall what it was!).

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25711/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25729/

@Trott
Copy link
Member

Trott commented Sep 27, 2019

Landed in f81bef5

@Trott Trott closed this Sep 27, 2019
Trott pushed a commit that referenced this pull request Sep 27, 2019
@XhmikosR @Trott
doc: fix 404 links
f81bef5 
For `www.cve.mitre.org` they don't seem to redirect www to naked.

PR-URL: #29661
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2019
@XhmikosR @targos
doc: fix 404 links
7a6b05a 
For `www.cve.mitre.org` they don't seem to redirect www to naked.

PR-URL: #29661
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XhmikosR @Trott @nodejs-github-bot @jasnell @gengjiawen @BridgeAR