Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix output in inspector HeapProfile example #29711

Closed
wants to merge 1 commit into from
Closed

doc: fix output in inspector HeapProfile example #29711

wants to merge 1 commit into from

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Sep 26, 2019 •
edited
Loading

Checklist

Example was added in #26498

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Sep 26, 2019
@Trott
Copy link
Member

Trott commented Sep 27, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3936/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2019
@Trott
Copy link
Member

Trott commented Sep 27, 2019

Landed in c484674

@Trott Trott closed this Sep 27, 2019
Trott pushed a commit that referenced this pull request Sep 27, 2019
@fanatid @Trott
doc: fix output in inspector HeapProfile example
c484674 
PR-URL: #29711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@fanatid fanatid deleted the doc-inspector-fix-heapprofiler branch September 28, 2019 05:26
targos pushed a commit that referenced this pull request Oct 1, 2019
@fanatid @targos
doc: fix output in inspector HeapProfile example
038cbb0 
PR-URL: #29711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fanatid @Trott @jasnell @lpinca @cjihrig @BridgeAR @nodejs-github-bot