stream: writable don't throw multiple callback error #30614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align ERR_MULTIPLE_CALLBACK in Writable with the rest of error handling as well as how the error is implemented in Transform.
nodejs-github-bot
added
the
stream
addaleax
added
the
semver-major
addaleax
approved these changes
Nov 23, 2019
lpinca
reviewed
Nov 24, 2019
ronag
force-pushed
the
stream-writable-err-multiple-callback
branch
from
80813ce
to
e5c3e85
Compare
|
Can you fix the test filename (test-stream-writable-callback-twice copy.js)? |
|
@lpinca: Yep, sorry. I'll try to be a bit more diligent. |
lpinca
approved these changes
Nov 24, 2019
|
@Trott: I believe this can land? |
|
It needs at least one more TSC approval as it is semver-major. cc: @nodejs/tsc |
|
Ah, sorry. I thought @lpinca was TSC. My mistake. |
jasnell
approved these changes
Dec 1, 2019
|
CITGM: https://ci.nodejs.org/view/All/job/citgm-smoker/2102/ (queued) |
|
@Trott: This has 2 TSC approvals and should be able to land? Anything in the CITGM? |
|
CITGM looks good. |
Trott
approved these changes
Dec 14, 2019
Trott
pushed a commit
that referenced
this pull request
Dec 14, 2019
Align ERR_MULTIPLE_CALLBACK in Writable with the rest of error handling as well as how the error is implemented in Transform. PR-URL: #30614 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in e902fad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align ERR_MULTIPLE_CALLBACK in Writable with the rest of error handling as well as how the error is implemented in Transform.
I've just basically copied the
Transformtest and made sureWritablematches it.Throwing here is dangerous and can lead to unnecessary unhandled exception.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes