Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: end(cb) cb can be invoked with error #32238

Closed
wants to merge 7 commits into from
Closed

docs: end(cb) cb can be invoked with error #32238

wants to merge 7 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Mar 12, 2020 •
edited
Loading

update docs that the optional callback passed to
writable.end can be invoked in case of an error as well

fixes: #31220

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@rexagod
docs: end(cb) cb can be invoked with error
35f4e6c 
update docs that the optional callback passed to
`writable.end` can be invoked in case of an error as well

fixes: nodejs#31220
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 12, 2020
mscdex
mscdex reviewed Mar 12, 2020
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
lpinca
lpinca approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add an entry in the changes: array of the YAML metadata.

@rexagod
Copy link
Member Author

rexagod commented Mar 14, 2020

@lpinca Sorry, I don't know what you meant by that. Could you explain that a bit? Thanks!

ronag
ronag reviewed Mar 14, 2020
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@lpinca
Copy link
Member

lpinca commented Mar 15, 2020

@rexagod see line 408-410. I mean an entry like that.

addaleax
addaleax reviewed Mar 29, 2020
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@rexagod rexagod requested a review from addaleax March 29, 2020 20:12
addaleax
addaleax reviewed Mar 29, 2020
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@rexagod @addaleax
Update doc/api/stream.md
78a6211 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@rexagod @addaleax
doc: stream.end(cb) cb can be invoked with error
6ade42b 
Update docs that the optional callback passed to
`writable.end` can be invoked in case of an error as well.

PR-URL: #32238
Fixes: #31220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

Landed in 6ade42b

@addaleax addaleax closed this Mar 30, 2020
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@ronag ronag ronag left review comments

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: end(cb) cb can be invoked with error
6 participants
@rexagod @lpinca @addaleax @mscdex @ronag @nodejs-github-bot