Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix win32 main thread detection #32823

Commits on Apr 13, 2020

  1. n-api: fix win32 main thread detection

    `uv_thread_self()` works on Windows only for threads created using
    `uv_thread_start()` because libuv does not use `GetCurrentThreadId()`
    for threads that were created otherwise. `uv_thread_equal()` works
    correctly.
    
    Thus, on Windows we use `GetCurrentThreadId()` to compare the main
    thread with the current thread.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Gabriel Schulhof committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    55e9481 View commit details
    Browse the repository at this point in the history
  2. ifdef the rest of the API

    Gabriel Schulhof committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    eb3231f View commit details
    Browse the repository at this point in the history
  3. convert to class

    Gabriel Schulhof committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    0678182 View commit details
    Browse the repository at this point in the history
  4. simplify definition

    Gabriel Schulhof committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    8980c7b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. add consts

    Co-Authored-By: Anna Henningsen <github@addaleax.net>
    Gabriel Schulhof and addaleax committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    2e61c71 View commit details
    Browse the repository at this point in the history