Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node from 1.15.0 to 1.15.1 #33727

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 4, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 4, 2020
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2020
@Trott
Copy link
Member Author

Trott commented Jun 4, 2020

(The code here is only run during linting, so GitHub Action results should be sufficient CI. Added author ready label.)

Trott added a commit that referenced this pull request Jun 6, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott closed this Jun 6, 2020
@Trott
Copy link
Member Author

Trott commented Jun 6, 2020

Landed in 065426c

@Trott Trott deleted the update-md-lint-1.15.1 branch June 6, 2020 12:50
Trott added a commit to Trott/io.js that referenced this pull request Jun 8, 2020
Linting the style guide is failing due to a recent addition in
nodejs#33755 landing before the lint
library being updated in nodejs#33727.
Sorry about the error.
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants