Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: introduce TimerWrap/TimerWrapHandle utility #34186

Closed
wants to merge 3 commits into from
Closed

src: introduce TimerWrap/TimerWrapHandle utility #34186

wants to merge 3 commits into from
+197 −171

Commits on Jul 5, 2020

  1. src: add TimerWrap utility 

    Consolidate uv_timer_t boilerplate code into a shared utility.
There are several places throughout the code where we use uv_timer_t
internally (inspector, perf, quic), with some code duplication.
This eliminates the duplicated code, ensures that cleanup occurs
correctly, and simplifies use of the timers.

Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    9707be1 View commit details
    Browse the repository at this point in the history

  2. src: replace InspectorTimer with TimerWrap utility 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    b4e7e57 View commit details
    Browse the repository at this point in the history

  3. quic: use TimerWrap for idle and retransmit timers 

    Signed-off-by: James M Snell <jasnell@gmail.com>
    @jasnell
    jasnell committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    f7ad0bf View commit details
    Browse the repository at this point in the history