test: disable test-tick-processor - aix and be ppc #3491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if the CI is happy now. Maybe drop the superfluous parentheses. |
| process.platform === 'aix' || | ||
| ((process.platform === 'linux') && | ||
| (process.arch === 'ppc64') && | ||
| (process.config.variables.node_byteorder === 'big')) || |
There was a problem hiding this comment.
The latter should be a helper.
Please also switch to using common.isWindows and common.isAix. :)
There was a problem hiding this comment.
os.endianness() is already defined
|
@Fishrock123 @jasnell updated to address comments. |
|
LGTM. The CI run is borked, however, due to a bad npm update. Will have to rerun after that is addressed. |
|
LGTM if CI is happy. CI is unborked now, so here's a new CI run: https://ci.nodejs.org/job/node-test-pull-request/577/ EDIT: First green node-test-commit-plinux ever! 🎉 |
| @@ -14,6 +14,11 @@ exports.tmpDirName = 'tmp'; | |||
| exports.PORT = +process.env.NODE_COMMON_PORT || 12346; | |||
| exports.isWindows = process.platform === 'win32'; | |||
| exports.isAix = process.platform === 'aix'; | |||
| exports.isLinuxPPCBE = (process.platform === 'linux') && | |||
There was a problem hiding this comment.
Nit that can totally be ignored: isLinuxPpcBe perhaps for consistency? (We don't do isFreeBSD or isSunOS for example.)
There was a problem hiding this comment.
Agreed on consistency but since I just added the ones for FreeBSD and SunOS I'll change those instead
|
Updated to improve captilization for SunOS and FreeBSD |
|
Another CI run after change https://ci.nodejs.org/job/node-test-pull-request/578/ |
|
Nice to see the ppc CI all green. LGTM |
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point.
|
Squashed down to 1 commit |
mhdawson
added a commit
that referenced
this pull request
Oct 23, 2015
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: #3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed as 5f3fb1c |
mhdawson
added a commit
to ibmruntimes/node
that referenced
this pull request
Oct 23, 2015
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: nodejs/node#3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
mhdawson
added a commit
that referenced
this pull request
Oct 26, 2015
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: #3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in v4.x-staging in bc2a80b |
mhdawson
added a commit
that referenced
this pull request
Oct 26, 2015
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: #3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Oct 27, 2015
mhdawson
added a commit
that referenced
this pull request
Oct 29, 2015
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: #3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is already partially disabled for several platforms with
the comment that the required info is not provided at the C++ level.
I'm adding AIX as and PPC BE linux as they currently fall into
the same category. We are working to see if we can change that
in v8 but it will be non-trivial if is possible at all so I don't
want to leave the CI with failing tests until that point.