tools: fix docopen target #35062
Closed
tools: fix docopen target #35062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before.
nodejs-github-bot
added
the
build
Codecov Report
@@ Coverage Diff @@
## master #35062 +/- ##
==========================================
- Coverage 96.69% 96.67% -0.03%
==========================================
Files 207 207
Lines 69191 69305 +114
==========================================
+ Hits 66902 66998 +96
- Misses 2289 2307 +18
Continue to review full report at Codecov.
|
richardlau
approved these changes
Sep 5, 2020
DerekNonGeneric
approved these changes
Sep 5, 2020
DerekNonGeneric
added
the
author ready
DerekNonGeneric
pushed a commit
that referenced
this pull request
Sep 6, 2020
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: #35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
|
Landed in 441c03d |
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: #35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: #35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: #35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: #35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: nodejs#35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it has not been built before.
$(apidocs_html)is part ofout/doc/api/all.htmlprerequisites, it's safe useout/doc/api/all.htmlas the only prerequisite here.node/Makefile
Lines 766 to 768 in f3b4846
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes