Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add entry to console.timeEnd() changes array #35441

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 1, 2020

Refs: #35027

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Oct 1, 2020
@puzpuzpuz puzpuzpuz self-requested a review October 1, 2020 15:03
@jasnell
Copy link
Member

jasnell commented Oct 1, 2020

This shouldn't need to wait to land. Fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 1, 2020
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#35441
Refs: nodejs#35027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca lpinca force-pushed the add/entry-for-console-timeend-changes branch from 5a6c5d4 to fa53a65 Compare October 4, 2020 05:57
@lpinca lpinca merged commit fa53a65 into nodejs:master Oct 4, 2020
@lpinca
Copy link
Member Author

lpinca commented Oct 4, 2020

Landed in fa53a65.

@lpinca lpinca deleted the add/entry-for-console-timeend-changes branch October 4, 2020 05:57
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #35441
Refs: #35027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35441
Refs: nodejs#35027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants