Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fixup scrypt regressions #35821

Closed
wants to merge 2 commits into from
Closed

crypto: fixup scrypt regressions #35821

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 26, 2020

Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: #35815

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell
crypto: fixup scrypt regressions
986fb5b 
Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: nodejs#35815
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 26, 2020
@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. regression Issues related to regressions. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 26, 2020
@jasnell jasnell mentioned this pull request Oct 26, 2020
Closed
addaleax
addaleax approved these changes Oct 26, 2020
View reviewed changes
src/crypto/crypto_util.cc Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33869/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2020
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33876/

mcollina
mcollina approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33881/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020
@github-actions
Copy link
Contributor

Landed in 30e9fab...05bb1b3

@github-actions github-actions bot closed this Oct 30, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2020
@jasnell @nodejs-github-bot
crypto: fixup scrypt regressions
05bb1b3 
Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: #35815

PR-URL: #35821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
@jasnell @targos
crypto: fixup scrypt regressions
79a8fb6 
Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: #35815

PR-URL: #35821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
tniessen added a commit to tniessen/node that referenced this pull request Nov 4, 2020
@tniessen
crypto: fix comment in ByteSource
cf73212 
Refs: nodejs#35821
@tniessen tniessen mentioned this pull request Nov 4, 2020
Closed
2 tasks
lpinca pushed a commit that referenced this pull request Nov 5, 2020
@tniessen @lpinca
crypto: fix comment in ByteSource
c9e3848 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@tniessen @danielleadams
crypto: fix comment in ByteSource
dc4936b 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto.scryptSync regression in Node 15: routines:EVP_PBE_scrypt:memory limit exceeded
8 participants
@jasnell @nodejs-github-bot @mcollina @Trott @addaleax @tniessen @BethGriggs @aduh95