Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example for setBreakpoint() with a conditional statement #35823

Merged
merged 0 commits into from
Oct 29, 2020

Conversation

copperwall
Copy link
Contributor

The node-inspect debugging client supports passing an optional third parameter as a string to be evaluated when the breakpoint is hit. If the condition evaluates to true in the current context, the breakpoint pauses execution, otherwise the execution continues.

This was raised as an issue in nodejs/node-inspect#68, but the client already supports that functionality, so I thought it'd be helpful to add it to the node documentation.

Checklist

@nodejs-github-bot nodejs-github-bot added debugger doc Issues and PRs related to the documentations. labels Oct 26, 2020
@Trott Trott requested a review from jkrems October 27, 2020 13:41
doc/api/debugger.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Oct 27, 2020

Welcome @copperwall and thanks for the pull request! I left a suggestion, but it's totally optional. Looks good to me either way.

Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, potentially with Trott's suggestion.

@Trott
Copy link
Member

Trott commented Oct 29, 2020

Landed in a3cc239

@Trott
Copy link
Member

Trott commented Oct 29, 2020

Thanks for the contribution! 🎉

@Trott Trott closed this Oct 29, 2020
@Trott Trott merged commit a3cc239 into nodejs:master Oct 29, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
The `node-inspect` debugging client supports passing an optional third
parameter as a string to be evaluated when the breakpoint is hit. If the
condition evaluates to `true` in the current context, the breakpoint
pauses execution; otherwise the execution continues.

This was raised as an issue in
nodejs/node-inspect#68, but the client already
supports that functionality, so I thought it'd be helpful to add it to
the node documentation.

PR-URL: #35823
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
The `node-inspect` debugging client supports passing an optional third
parameter as a string to be evaluated when the breakpoint is hit. If the
condition evaluates to `true` in the current context, the breakpoint
pauses execution; otherwise the execution continues.

This was raised as an issue in
nodejs/node-inspect#68, but the client already
supports that functionality, so I thought it'd be helpful to add it to
the node documentation.

PR-URL: #35823
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
The `node-inspect` debugging client supports passing an optional third
parameter as a string to be evaluated when the breakpoint is hit. If the
condition evaluates to `true` in the current context, the breakpoint
pauses execution; otherwise the execution continues.

This was raised as an issue in
nodejs/node-inspect#68, but the client already
supports that functionality, so I thought it'd be helpful to add it to
the node documentation.

PR-URL: #35823
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
The `node-inspect` debugging client supports passing an optional third
parameter as a string to be evaluated when the breakpoint is hit. If the
condition evaluates to `true` in the current context, the breakpoint
pauses execution; otherwise the execution continues.

This was raised as an issue in
nodejs/node-inspect#68, but the client already
supports that functionality, so I thought it'd be helpful to add it to
the node documentation.

PR-URL: #35823
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants