Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove some duplication in DeserializeProps #36336

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 1, 2020

This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 1, 2020
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the "dupclication" typo in the commit message on landing.

This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.
@danbev danbev changed the title src: remove some dupclication in DeserializeProps src: remove some duplication in DeserializeProps Dec 3, 2020
danbev added a commit that referenced this pull request Dec 4, 2020
This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.

PR-URL: #36336
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danbev
Copy link
Contributor Author

danbev commented Dec 4, 2020

Landed in ff28ab7.

@danbev danbev closed this Dec 4, 2020
@danbev danbev deleted the env-deserialize-macro branch December 4, 2020 07:54
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.

PR-URL: #36336
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.

PR-URL: nodejs#36336
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants