Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use ESM syntax for WASI example #36848

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 8, 2021

Using top-level await and ESM makes sense here I think, and it makes the example easier to follow.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 8, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 12, 2021

@nodejs/wasi

Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jan 13, 2021

Somehow this turned into 101 files being changed? If that's intentional, I think the commits should be split out into separate PRs.

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 13, 2021

Somehow this turned into 101 files being changed? If that's intentional, I think the commits should be split out into separate PRs.

There are two commits, one to add the TLA syntax to the linter, and one to make the change this PR is about. I'm opening #36911 to this PR about WASI docs only.

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Jan 13, 2021
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WASI docs change LGTM.

PR-URL: nodejs#36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@aduh95 aduh95 merged commit 88a5426 into nodejs:master Jan 15, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 15, 2021

Landed in 88a5426

@aduh95 aduh95 deleted the wasi-doc-esm branch January 15, 2021 23:35
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 15, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants