Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: fix Windows folder exports deprecation warning #36859

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

guybedford
Copy link
Contributor

This fixes an issue with the deprecation warning introduced in #35747 which was triggering incorrectly for third-party package resolutions in Windows.

Should have tested the negative case fully, but at least it has made people aware of the deprecation who have been using Node.js 15.

An alternative might be to just go ahead and apply this warning for all resolutions anyway, but let's stick to the plan of a slow deprecation for now at least.

@nodejs/modules

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#36859
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@aduh95 aduh95 force-pushed the subpath-deprecation-win-fix branch from 6daadf1 to 2e909c4 Compare January 12, 2021 13:46
@aduh95
Copy link
Contributor

aduh95 commented Jan 12, 2021

Landed in 2e909c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants