Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise premature disclosure text in collborator guide #37524

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 26, 2021

Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2021
@RaisinTen
Copy link
Contributor

@Trott nit: in the commit title, dicslosure->disclosure

@Trott Trott changed the title doc: revise premature dicslosure text in collborator guide doc: revise premature disclosure text in collborator guide Feb 27, 2021
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: collborator -> collaborator (title is too long for a commit message anyway)

Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.

PR-URL: nodejs#37524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Copy link
Member Author

Trott commented Mar 1, 2021

Landed in 2fd1db8

@Trott Trott merged commit 2fd1db8 into nodejs:master Mar 1, 2021
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.

PR-URL: nodejs#37524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 2, 2021
Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.

PR-URL: #37524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request May 1, 2021
Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.

PR-URL: #37524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request May 3, 2021
@Trott Trott deleted the premature-disclosure branch September 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants