Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix small typo in 15.11.0 release #37590

Closed
wants to merge 1 commit into from

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Mar 3, 2021

Noticed a small typo in the changelog for the release today while writing a tweet for it, wanted to help fix it. Since this typo is directly committed and is in the commit message, I'm not sure if this can/should land but figured I'd throw it up on the possibility that folks think it should land.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 3, 2021
@bnb
Copy link
Contributor Author

bnb commented Mar 3, 2021

did my best with the commit message naming, if doc: is more correct than changelog: happy to fix that.

@bnb
Copy link
Contributor Author

bnb commented Mar 3, 2021

removed the change in the auto-generated bit and to just update the Notable Changes bit, per advice from @MylesBorins.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTen
Copy link
Contributor

Looking at the last two typo fixes in this changelog (#37229 and #35804), it seems doc: is preferred over changelog:.

@bnb
Copy link
Contributor Author

bnb commented Mar 4, 2021

Will update that today 👍🏻

@bnb bnb changed the title changelog: fix small typo in 15.11.0 release doc: fix small typo in 15.11.0 release Mar 4, 2021
@bnb
Copy link
Contributor Author

bnb commented Mar 4, 2021

Force pushed over the previous commit to use the doc prefix ❤️

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@bnb
Copy link
Contributor Author

bnb commented Mar 5, 2021

The failed macOS build is unrelated to the contents of this PR 😬

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
PR-URL: #37590
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

Landed in ed633f2

@jasnell jasnell closed this Mar 5, 2021
@bnb bnb deleted the bnb/changelog-typo-fix branch March 11, 2021 15:52
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37590
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants