Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.0.257.13 #37830

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.0.257.13 #37830

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 20, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 20, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36837/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3855/

cjihrig
cjihrig approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36864/

jasnell
jasnell approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@jasnell
Copy link
Member

jasnell commented Mar 22, 2021

Landed in d639321

@jasnell jasnell closed this Mar 22, 2021
jasnell pushed a commit that referenced this pull request Mar 22, 2021
@targos @jasnell
deps: patch V8 to 9.0.257.13
d639321 
Refs: v8/v8@9.0.257.11...9.0.257.13

PR-URL: #37830
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the v8-257-13 branch March 22, 2021 15:22
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @jasnell @cjihrig