Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE #37890

Closed
wants to merge 3 commits into from
Closed

test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE #37890

wants to merge 3 commits into from

Conversation

peZhmanParsaee
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 24, 2021
@addaleax addaleax removed the needs-ci PRs that need a full CI run. label Mar 24, 2021
RaisinTen
RaisinTen previously approved these changes Mar 24, 2021
View reviewed changes
@RaisinTen RaisinTen dismissed their stale review March 24, 2021 15:47

tests failed

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37843/ 💚

@jasnell
Copy link
Member

jasnell commented Apr 30, 2021

Landed in 3c6ff9e

@jasnell jasnell closed this Apr 30, 2021
jasnell pushed a commit that referenced this pull request Apr 30, 2021
@peZhmanParsaee @jasnell
test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE
3c6ff9e 
PR-URL: #37890
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request May 3, 2021
@peZhmanParsaee @targos
test: crypto KeyObject.from() ERR_INVALID_ARG_TYPE
67e9e71 
PR-URL: #37890
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@peZhmanParsaee @nodejs-github-bot @jasnell @panva @addaleax @cjihrig @juanarbol @RaisinTen @targos