Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] src: move CHECK in AddIsolateFinishedCallback #38010

Closed
wants to merge 1 commit into from
Closed

[v12.x] src: move CHECK in AddIsolateFinishedCallback #38010

wants to merge 1 commit into from

Commits on Mar 31, 2021

  1. src: move CHECK in AddIsolateFinishedCallback 

    `CHECK(it->second)` asserts that we have `PerIsolatePlatformData`
in the `per_isolate_` map, and not just a key with empty value. When
`it == per_isolate_.end()`, however, it means that we don't have the
isolate and the `CHECK(it->second)` is guaranteed to fail then!
    @indutny
    indutny committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ad7f207 View commit details
    Browse the repository at this point in the history