Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: deserializer.readDouble() crashes process #38031

Conversation

EladKeyshawn
Copy link

Hey there I'm really new here but I wanted to make a suggestion for fixing the problem from issue #37978
Thanks again in advance 🔥

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 1, 2021
@mscdex
Copy link
Contributor

mscdex commented Apr 1, 2021

Changes to V8 need to be made upstream.

@aduh95
Copy link
Contributor

aduh95 commented Apr 2, 2021

Thanks for sending a PR. Changes done in deps/v8 needs to land in V8 repo first. You can check out https://v8.dev/docs/contribute for instructions.

Closing this PR now; once the patch lands upstream, you can reopen or open a new PR as you prefer.

@aduh95 aduh95 closed this Apr 2, 2021
@EladKeyshawn EladKeyshawn changed the title suggestion V8: deserializer.readDouble() crashes process Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants