Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update OpenSSL 3.x expected error message #38164

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 9, 2021

This commit updates an expected error message which has changed in
OpenSSl 3.x. OpenSSL 3.0 is still under development but once there is a
relase we should not be seeing test failure like this.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 9, 2021
@danbev danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2021
@richardlau
Copy link
Member

This started failing with OpenSSL 3 alpha 14 (nodejs/build#2613 (comment)). 👍 to fast track to unbreak the CI.

@nodejs-github-bot
Copy link
Collaborator

@danbev
Copy link
Contributor Author

danbev commented Apr 9, 2021

The failure in node-test-linux-linked-openssl300 is expected and should be fixed by #38165.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Apr 9, 2021

The failure in node-test-linux-linked-openssl300 is expected and should be fixed by #38165.

That PR has landed so now we should be able to get a green CI....

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

This commit updates an expected error message which has changed in
OpenSSl 3.x. OpenSSL 3.0 is still under development but once there is a
relase we should not be seeing test failure like this.

PR-URL: nodejs#38164
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the openssl_test_crypto_dh_error_msg branch from d198e20 to 7216eb6 Compare April 9, 2021 21:54
@aduh95
Copy link
Contributor

aduh95 commented Apr 9, 2021

Landed in 7216eb6

@aduh95 aduh95 closed this Apr 9, 2021
@aduh95 aduh95 merged commit 7216eb6 into nodejs:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants