Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: add types for internalBinding('fs') #38198

Closed
wants to merge 2 commits into from
Closed

typings: add types for internalBinding('fs') #38198

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 11, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Apr 11, 2021
@targos targos force-pushed the internal-fs-binding-typings branch from 81ed32d to 3490e6d Compare April 11, 2021 08:54
targos
targos commented Apr 11, 2021
View reviewed changes
typings/internalBinding.d.ts Outdated Show resolved Hide resolved
@targos
Copy link
Member Author

targos commented Apr 11, 2021

@bmeck What do you think about typings as a subsystem? Something like internal-typings would be clearer about the fact that the types are not exposed to user code, but it's a bit long for the first line of a commit message...

targos
targos commented Apr 11, 2021
View reviewed changes
typings/internalBinding.d.ts Outdated Show resolved Hide resolved
@targos targos added the typings label Apr 11, 2021
@bmeck
Copy link
Member

bmeck commented Apr 11, 2021

@targos seems fine to add that subsystem, I did not expect as many PRs/size of them to come in as are showing up so might want to do this quickly

@targos
Copy link
Member Author

targos commented Apr 12, 2021

@Trott is there something to update (documentation? tooling?) to add a new subsystem?

@bmeck
Copy link
Member

bmeck commented Apr 12, 2021

@targos updating https://github.com/nodejs/core-validate-commit to have it in the subsystem rules is the main thing

targos added a commit to targos/core-validate-commit that referenced this pull request Apr 12, 2021
@targos
rules: add "typings" subsystem
e9172db 
Refs: nodejs/node#38198
@targos targos mentioned this pull request Apr 12, 2021
Merged
@targos
Copy link
Member Author

targos commented Apr 12, 2021

Created nodejs/core-validate-commit#92

@Trott
Copy link
Member

Trott commented Apr 13, 2021

@Trott is there something to update (documentation? tooling?) to add a new subsystem?

Other than what @bmeck said about core-validate-commit, I don't know of anything. It might be nice to add an entry to the who-to-cc table in the collaborator guide, but that can always happen later.

targos added a commit to nodejs/core-validate-commit that referenced this pull request Apr 13, 2021
@targos
rules: add "typings" subsystem (#92)
7b97be3 
Refs: nodejs/node#38198
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37437/

@targos targos mentioned this pull request Apr 13, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37451/

@targos targos self-assigned this Apr 14, 2021
targos added a commit that referenced this pull request Apr 14, 2021
@targos
typings: add types for internalBinding('fs')
cb2bdc6 
PR-URL: #38198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
Copy link
Member Author

targos commented Apr 14, 2021

Landed in cb2bdc6

@targos targos closed this Apr 14, 2021
@targos targos deleted the internal-fs-binding-typings branch April 14, 2021 10:27
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@targos @BethGriggs
typings: add types for internalBinding('fs')
76d3ab8 
PR-URL: #38198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @bmeck @Trott @nodejs-github-bot @jasnell