Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: add range validation to debugPort #38205

Closed
wants to merge 1 commit into from
Closed

process: add range validation to debugPort #38205

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 11, 2021

This commit adds validation to the process.debugPort setter.

Fixes: #38037

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 11, 2021
@cjihrig
process: add range validation to debugPort
e1463bf 
This commit adds validation to the process.debugPort setter.

Fixes: nodejs#38037
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2021 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37386/ 💚

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2021
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Apr 12, 2021
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

CI is green and this has plenty of reviews. It really shouldn't have to wait the 48 hours to land. Please 👍🏻 to fast-track

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2021
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

Landed in 13c931a

@jasnell jasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@cjihrig @jasnell
process: add range validation to debugPort
13c931a 
This commit adds validation to the process.debugPort setter.

Fixes: #38037

PR-URL: #38205
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@cjihrig cjihrig deleted the port branch April 12, 2021 22:06
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@cjihrig @BethGriggs
process: add range validation to debugPort
8023937 
This commit adds validation to the process.debugPort setter.

Fixes: #38037

PR-URL: #38205
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign process.debugPort with some value may results in an abort
9 participants
@cjihrig @nodejs-github-bot @jasnell @Trott @addaleax @lpinca @aduh95 @RaisinTen @targos