Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.0.257.21 #38333

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.0.257.21 #38333

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 21, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 21, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37591/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3948/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37651/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37735/

@jasnell
Copy link
Member

jasnell commented Apr 26, 2021

Landed in 3b86138

@jasnell jasnell closed this Apr 26, 2021
jasnell pushed a commit that referenced this pull request Apr 26, 2021
@targos @jasnell
deps: patch V8 to 9.0.257.21
3b86138 
Refs: v8/v8@9.0.257.19...9.0.257.21

PR-URL: #38333
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the v8-9.0.257.21 branch April 26, 2021 19:48
targos added a commit that referenced this pull request Apr 29, 2021
@targos
deps: patch V8 to 9.0.257.21
f455e08 
Refs: v8/v8@9.0.257.19...9.0.257.21

PR-URL: #38333
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @jasnell @cjihrig @gengjiawen @richardlau