tools: remove redundant v8 config #38565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoltrexKeyva
approved these changes
May 6, 2021
targos
approved these changes
May 6, 2021
richardlau
approved these changes
May 6, 2021
ryzokuken
approved these changes
May 6, 2021
addaleax
approved these changes
May 6, 2021
cjihrig
approved these changes
May 7, 2021
jasnell
approved these changes
May 7, 2021
jasnell
added
fast-track
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
May 8, 2021
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
May 8, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gengjiawen
added a commit
that referenced
this pull request
May 18, 2021
PR-URL: #38565 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 910efc2 |
targos
pushed a commit
that referenced
this pull request
May 18, 2021
PR-URL: #38565 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removed in v8 8.8 v8/v8@50ddb12#diff-d7acea6210a7cc323c71038bc347fc751c62b8f13566c9dcdbc212328c8efa44
cc @nodejs/v8